Repository navigation
Fix sky scan orientation, p-value plots and wording in the tutorials - #340
Open
tomaskontrimas wants to merge 2 commits into
Open
tomaskontrimas wants to merge 2 commits into
tomaskontrimas wants to merge 2 commits into
Conversation
tomaskontrimas
requested review from
chiarabellenghi
and
a balanced review from Copilot
October 28, 2026 21:55
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
The dataset concept notebook failed to execute, because it used the
non-existing WGETDatasetTransfer.post_transfer_unzip method as post
transfer function. Use the post_transfer_unarchive function instead,
which extracts .zip, .tar.gz, .tgz, .tar.bz2, and .tar.xz archives.
Update the notebook to the current API: mention all three transfer
methods (rsync, wget, urlretrieve), add an example for an origin given
as a complete download URL (as used for the IceCube public data), fix
typos, and store the outputs of a fresh execution. No data is
downloaded by the notebook.
The notebook also revealed that DatasetOrigin.__str__ printed the name
of the metaclass ("ABCMeta") as transfer class, or "NoneType" for plain
transfer functions. Print the name of the transfer class, or of the
transfer function, instead.
tomaskontrimas
force-pushed
the
tutorial-fixes
branch
from
November 2, 2026 17:59
539b6b9 to
a4d3ff9
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug in the sky scan tutorial, plus incorrect statements, stale hard-coded values and typos across the tutorial
notebooks.
sky_scan.ipynb:
[ra_idx, dec_idx], butpcolormesh/contourexpect[dec_idx, ra_idx]. Because the grid is square, this didn't raise an error. The same mismatch swapped the R.A. and Dec. of the best-fit marker.p_value_method_comparison.ipynb:
calculate_critical_ts_from_gammanow uses the sameetaas the fit (it was hard-coded to 1.0 before).concepts/dataset.ipynb:
WGETDatasetTransfer.post_transfer_unzipas post-transfer function. It now usespost_transfer_unarchive.DatasetOrigin.__str__: printed the metaclass name (ABCMeta) as the transfer class, orNoneTypefor plain transfer functions. It now prints the name of the transfer class or function.Other corrections to the text, e.g. point-source flux units without
sr^-1, the Wilks' theorem degrees of freedom in the sky scan, and why the time-dependent analysis finds the 2014–2015 flare of TXS 0506+056.